Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kube-router Should Own CNI Plugin Installation Process #1600

Closed
aauren opened this issue Jan 25, 2024 · 2 comments · Fixed by #1601
Closed

kube-router Should Own CNI Plugin Installation Process #1600

aauren opened this issue Jan 25, 2024 · 2 comments · Fixed by #1601
Labels
Milestone

Comments

@aauren
Copy link
Collaborator

aauren commented Jan 25, 2024

Describe the solution you'd like

In order for kube-router to better align with other Kubernetes networking providers and to improve the end-user experience, kube-router should bundle and install CNI plugins to the host's system when they are missing.

This should be in an initContainer to limit the host mounts that kube-router carries during it's runtime.

Additionally, user's should be able to opt-out of this process by manipulating the daemonset or setting a flag or some such.

Describe alternatives you've considered

kube-router could continue not owning this process, but it puts more onus on the user to make sure that this is available and given that most networking providers appear to do this, it violates the principle of least surprise for normal Kubernetes users.

Additional context

Antrea has kindly provided a link to their implementation for this process here:
https://github.com/antrea-io/antrea/blob/main/build/images/scripts/install_cni

@aauren aauren added the feature label Jan 25, 2024
@aauren aauren added this to the v2.1.0 milestone Jan 25, 2024
@aauren
Copy link
Collaborator Author

aauren commented Jan 26, 2024

@aauren
Copy link
Collaborator Author

aauren commented Jan 31, 2024

As a side note, this was also blocking kube-router from working effectively on the RKE2 platform as RKE2 expected the network provider to bring its own CNI plugins.

With this fixed, kube-router should now work "out of the box" on RKE2. Although obviously, rancher/rke#3404 would provide an even better integration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant