You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
loader.cc calls dhcp_start(true). This "true" causes the initialization to wait until DHCP succeeds. If DHCP does not succeed, OSv will hang forever, silently because dhcp.cc uses dhcp_i which doesn't show anything (unless the -V option is used for verbose output). In this case the user is clueless why OSv is hanging. This can happen for example when the "-n" option is used (for using tap) but there is no DHCP server running (e.g., libvirt is not running).
We need be verbose (regardless of the -V option) when DHCP is not successful after a reasonable amount of time. It would also be nice for OSv to come up without networking in that case, instead of hanging forever.
The text was updated successfully, but these errors were encountered:
How about, we modify dhcp_start, to take the number of attempts as an argument?
We could use a signed int, and represent an infinite number of attempts as a negative value.
loader.cc calls dhcp_start(true). This "true" causes the initialization to wait until DHCP succeeds. If DHCP does not succeed, OSv will hang forever, silently because dhcp.cc uses dhcp_i which doesn't show anything (unless the -V option is used for verbose output). In this case the user is clueless why OSv is hanging. This can happen for example when the "-n" option is used (for using tap) but there is no DHCP server running (e.g., libvirt is not running).
We need be verbose (regardless of the -V option) when DHCP is not successful after a reasonable amount of time. It would also be nice for OSv to come up without networking in that case, instead of hanging forever.
The text was updated successfully, but these errors were encountered: