Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test failure in tracing_smoke_test #1177

Closed
nyh opened this issue Nov 22, 2021 · 1 comment
Closed

Test failure in tracing_smoke_test #1177

nyh opened this issue Nov 22, 2021 · 1 comment

Comments

@nyh
Copy link
Contributor

nyh commented Nov 22, 2021

After fixing #1175 preventing "tracing_smoke_test" from running on my Fedora 34 machine, I get a new failure for "make check":

  TEST tracing_smoke_test
...
  File "/home/nyh/osv.tmp2/osv/scripts/loader.py", line 1312, in save_traces_to_file
...
  File "/home/nyh/osv.tmp2/osv/scripts/loader.py", line 1290, in one_cpu_trace
    thread_name = thread_name.partition(b'\0')[0].decode()
UnicodeDecodeError: 'utf-8' codec can't decode byte 0x89 in position 2: invalid start byte

The thread_name we tried to decode was b'UH\x89\xf2H\x89\xfeH\x89\xe5SH\x8d}\xe8H' which doesn't look right.

@wkozaczuk I remember you recently did some patches around the tracing feature - did you change anything in its format that could break this test?

@nyh
Copy link
Contributor Author

nyh commented Nov 29, 2021

This is an invalid issue caused by an incorrect fix for #1175. A correct fix won't cause this failure. So closing.

@nyh nyh closed this as completed Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant