ME-14916-picture-in-picture #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehab-cl
approved these changes
Jan 25, 2024
Comment on lines
+12
to
+13
| chaptersButton: false, | ||
| pictureInPictureToggle: false, |
There was a problem hiding this comment.
these are no longer from videojs perspective part of the controlBar?
There was a problem hiding this comment.
they are the same buttons, children of the controlBar, only that we expose the setting as part of our root config
| @@ -368,6 +372,12 @@ class VideoPlayer extends Utils.mixin(Eventable) { | |||
| } | |||
| } | |||
|
|
|||
| _initPictureInPicture() { | |||
| if (!this.playerOptions.pictureInPictureToggle && this.videojs.controlBar) { | |||
| this.videojs.controlBar.removeChild('pictureInPictureToggle'); | |||
There was a problem hiding this comment.
just making sure i understand, we have to do this because the default for videojs is true right?
There was a problem hiding this comment.
Yes, and we want it hidden by default
This was referenced Feb 13, 2024
Merged
This was referenced Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.