Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normal HTML attributes aren't being applied correctly #6

Closed
webbower opened this issue Jan 2, 2017 · 2 comments
Closed

Normal HTML attributes aren't being applied correctly #6

webbower opened this issue Jan 2, 2017 · 2 comments
Assignees
Labels

Comments

@webbower
Copy link

webbower commented Jan 2, 2017

When I use the Image component and I pass in normal HTML attributes, including native event handlers, they are getting converted to snake case inside the Image component and so they are ignored by React's img component (attributes and handlers aren't being applied properly to the resulting HTML element). You can see what I'm talking about in the attached screenshot of the React dev tools.

developer_tools_-_http___localhost_3000_products_my-product-3_trk_vendor_dashboard_products_panel

My suspicion is that the function call on this line https://github.com/cloudinary/cloudinary-react/blob/master/src/components/Image/Image.js#L107 is not handling the React-style of camel case attributes correctly. And there doesn't seem to be any notes on how to specially handle native HTML attributes in the docs for this component.

@tocker
Copy link
Contributor

tocker commented Feb 6, 2017

Hi @webbower, thanks for reporting this!
I verified the issue and a fix will be posted soon.

@tocker tocker self-assigned this Feb 6, 2017
@tocker tocker added the bug label Feb 6, 2017
@webbower
Copy link
Author

webbower commented Feb 9, 2017

@tocker Awesome! Thanks.

@tocker tocker closed this as completed in 86996f5 Mar 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants