Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pattern(s) for label/form layout #1258

Closed
tylersticka opened this issue Jun 3, 2021 · 0 comments · Fixed by #1296
Closed

Add pattern(s) for label/form layout #1258

tylersticka opened this issue Jun 3, 2021 · 0 comments · Fixed by #1296
Assignees
Labels

Comments

@tylersticka
Copy link
Member

This issue was requested by @calebeby as part of this discussion: #1256 (comment)

This label/input relationship in the comment form (#1216) seems to repeat:

Screen Shot 2021-06-03 at 11 51 36 AM

Screen Shot 2021-06-03 at 11 51 39 AM

Screen Shot 2021-06-03 at 11 51 47 AM

This also appears to be the case for the WIP email signup form (#1088):

screen_shot_2021-06-03_at_9 55 25_am

Screen Shot 2021-06-03 at 9 57 10 AM

This suggests that we may want to create a new layout object pattern representing the label and a form field together. In the future, this could be extended to support additional messaging below inputs, but for now the existing use cases are all that's required.

Similar patterns in the wild:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants