Patch Review & Acceptance
This is a 3 steps process as outlined below:
- Step 1 - Automated test – Automated tests are being run using Travis. Whenever a PR is pushed travis run automated test on the PR. These tests are a combination of unit test, code checks for quality, CLA checks on the contributor.
-
Step 2 – Peer Review - This can be done by anyone however it is required that at-least 2 core contributors gives it acceptance on the patch. Core contributor will have the power to give a +2. However, a normal reviewer (which could be anyone) can give a +1 on the patch. At-least 2 “+2” are required for a patch to be approved. Use the "Start a Review" option in Github while making a review. Core reviewers can consider the following guidelines while evaluating the patch
- Commit messages – This should clearly explain which bug this fix addresses, this should also clearly explain what is being proposed by the contributor
- Code quality & standards
- Unit tests
- Proper logging
- Proper comments
- Local builds
- Readability of Code
- Step 3 – Acceptance & Merge – Once a patch has passed successfully through automated test and peer reviews one of the core committer should merge the fix. Please also recognize the contributor who has submitted this patch.
