From 2aa88271ed5a3fae92badd798744779ee5fb2da1 Mon Sep 17 00:00:00 2001 From: Philipp Thun Date: Mon, 13 Nov 2023 13:53:02 +0100 Subject: [PATCH] Remove unreachable rescue The binding's state is already checked before and if it is not in state 'create succeeded', a ResourceNotFound error is raised. Thus the LockCheck error can never be raised. --- app/controllers/v3/service_credential_bindings_controller.rb | 2 -- app/controllers/v3/service_route_bindings_controller.rb | 2 -- 2 files changed, 4 deletions(-) diff --git a/app/controllers/v3/service_credential_bindings_controller.rb b/app/controllers/v3/service_credential_bindings_controller.rb index addd9ff02af..3010706ddab 100644 --- a/app/controllers/v3/service_credential_bindings_controller.rb +++ b/app/controllers/v3/service_credential_bindings_controller.rb @@ -167,8 +167,6 @@ def parameters raise CloudController::Errors::ApiError. new_from_details('ServiceFetchBindingParametersNotSupported'). with_response_code(502) - rescue LockCheck::ServiceBindingLockedError => e - raise CloudController::Errors::ApiError.new_from_details('AsyncServiceBindingOperationInProgress', e.service_binding.app.name, e.service_binding.service_instance.name) end private diff --git a/app/controllers/v3/service_route_bindings_controller.rb b/app/controllers/v3/service_route_bindings_controller.rb index 3e94a0154ea..800a0aaedae 100644 --- a/app/controllers/v3/service_route_bindings_controller.rb +++ b/app/controllers/v3/service_route_bindings_controller.rb @@ -120,8 +120,6 @@ def parameters rescue ServiceBindingRead::NotSupportedError bad_request!('user provided service instances do not support fetching route bindings parameters.') if @route_binding.service_instance.user_provided_instance? bad_request!('this service does not support fetching route bindings parameters.') - rescue LockCheck::ServiceBindingLockedError - unprocessable!('There is an operation in progress for the service route binding.') end private