fix: default watch_dir to src of project directory
#646
Conversation
🦋 Changeset detectedLatest commit: 2fb8e48 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/2010721608/npm-package-wrangler-646You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/646/npm-package-wrangler-646Or you can use npx https://prerelease-registry.developers.workers.dev/runs/2010721608/npm-package-wrangler-646 dev path/to/script.js |
threepointone
force-pushed
the
default-watch-dir
branch
from
7840fcb to
5c6485c
Compare
|
I tested the prerelease build with https://github.com/jahands/wrangler-dev-example and it worked! Nice. |
| command | ||
| ? configPath | ||
| ? path.relative( | ||
| process.cwd(), |
There was a problem hiding this comment.
Generally I think we need to be making these paths relative to the wrangler.toml. The reason is that otherwise the following would have different results:
wrangler -c path/to/wrangler.toml ...
cd path/to
wrangler -c wrangler.tomlThere was a problem hiding this comment.
sorry, I don't understand. what would be the difference with these two? they would both resolve a watch_dir config to the same path, unless I'm missing something
There was a problem hiding this comment.
it does resolve against wrangler.toml's path in the next line
There was a problem hiding this comment.
OK, so I see my confusion now. You are saying that the configPath is always, already, relative to the cwd() (or it is absolute).
In that case there is no need for the relative(process.cwd(), ...) bit then, right?
There was a problem hiding this comment.
Just a personal preference, I don't like seeing absolute paths if and when I log this during development. Is that a problem?
There was a problem hiding this comment.
This is exactly how we normalised paths for wasm_modules and text_blobs too
There was a problem hiding this comment.
OK - it just really confused me, because if it is possible that configPath is not relative to src then this would break.
Happy to go with this for the timebeing.
There was a problem hiding this comment.
Yeah of the wrangler.Tom isn't adjacent to a src directory then this won't work. Honestly I think there shouldn't have been a default for that field at all (much like upload.dir)
|
dammit forgot a changeset |
Via wrangler 1, when using custom builds in `wrangler dev`, `watch_dir` should default to `src` of the "project directory" (i.e - wherever the `wrangler.toml` is defined if it exists, else in the cwd. Fixes #631
threepointone
force-pushed
the
default-watch-dir
branch
from
5c6485c to
2fb8e48
Compare
| command | ||
| ? configPath | ||
| ? path.relative( | ||
| process.cwd(), |
There was a problem hiding this comment.
OK - it just really confused me, because if it is possible that configPath is not relative to src then this would break.
Happy to go with this for the timebeing.
Via wrangler 1, when using custom builds in
wrangler dev,watch_dirshould default tosrcof the "project directory" (i.e - wherever thewrangler.tomlis defined if it exists, else in the cwd.Fixes #631