fix: improve authentication logging and warnings #645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 26a709b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/2009312857/npm-package-wrangler-645You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/645/npm-package-wrangler-645Or you can use npx https://prerelease-registry.developers.workers.dev/runs/2009312857/npm-package-wrangler-645 dev path/to/script.js |
JacobMGEvans
approved these changes
Mar 19, 2022
| @@ -365,6 +372,13 @@ function throwIfNotInitialised() { | |||
|
|
|||
| export function getAPIToken(): string | undefined { | |||
| throwIfNotInitialised(); | |||
| if (LocalState.api_token) { | |||
| console.warn( | |||
| "It looks like you have used Wrangler 1's `config` command to login with an API token.\n" + | |||
There was a problem hiding this comment.
tempted to just ignore the field and proceed as if the user isn't logged in.
There was a problem hiding this comment.
That is what we do at the moment, and it was causing confusion. See #526
Hence this PR.
petebacondarwin
force-pushed
the
api-token-warning
branch
from
22f6e40 to
0708070
Compare
- If a user has previously logged in via Wrangler 1 with an API token, we now display a helpful warning. - When logging in and out, we no longer display the path to the internal user auh config file. - When logging in, we now display an initial message to indicate the authentication flow is starting. Fixes [cloudflare#526](cloudflare#526)
petebacondarwin
force-pushed
the
api-token-warning
branch
from
0708070 to
26a709b
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #526