This repository has been archived by the owner on Aug 3, 2023. It is now read-only.
Fix Rust Live Preview #699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…even necessary for rust and javascript workers
gabbifish
commented
Sep 24, 2019
gabbifish
commented
Sep 24, 2019
ashleymichal
approved these changes
Oct 23, 2019
EverlastingBugstopper
approved these changes
Oct 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #618. The problem with Rust live preview was that it would keep on detecting changes as the rust-wasm toolchain built the wasm worker, meaning that changes to source code would trigger a cascade of file changes and thus, a cascade of file detection events and updates sent to the preview service. (So the problem wasn't dotfiles, afaik)...
This PR filters target/build paths for rust-wasm so they are not watched for file changes; namely, this includes the
pkg,target, andworker-generateddirectories.This has been tested on a Linux computer with Javascript, Webpack, and Rust workers and works as expected. Additional manual/real-world testing of this would be appreciated, especially on other operating systems (Mac, Windows)!
This PR also fixes watching of dotfiles for rust live preview.