This repository has been archived by the owner on Aug 3, 2023. It is now read-only.
Migrate straggler emojis to terminal::emoji #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EverlastingBugstopper
force-pushed
the
avery/fix-emojis
branch
from
e2d58e3 to
58bb7ea
Compare
gabbifish
suggested changes
Aug 2, 2019
EverlastingBugstopper
force-pushed
the
avery/fix-emojis
branch
from
58bb7ea to
4b1eb87
Compare
ashleygwilliams
approved these changes
Aug 5, 2019
ashleymichal
approved these changes
Aug 5, 2019
EverlastingBugstopper
added
status - needs review
and removed
status - needs review
labels
EverlastingBugstopper
force-pushed
the
avery/fix-emojis
branch
from
5c2263c to
fded549
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes a few remaining instances where warngler was using hard-coded emojis for messages rather than⚠️ , but the rest is simply a change in implementation.
terminal::emoji. There are two instances where this changes ⛔ to