This repository has been archived by the owner on Aug 3, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 334
Update README to include config, env var changes #379
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabbifish
approved these changes
Aug 1, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only one minor nit in two areas. Otherwise LGTM :)
@gabbifish @ashleymichal I ran the demo GIF through gifsicle and shrinked it from over 1mb to ~200kb! Want to update with this? |
vaguely blocked on this cloudflare/worker-template#14 |
cloudflare/worker-template#14 is merged |
kristianfreeman
approved these changes
Aug 9, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For 1.1.0 we updated
wrangler config
to be an interactive prompt for security reasons, but we also introduced environment variables for the values configured with that command for the sake of users integrating Wrangler into their CI pipelines. This PR updates the README to reflect those changes.Fixes #378 , #377