feat: allow custom webpack configuration in wrangler.toml #253
Conversation
|
Side note: Rust is so cool. This is my first Rust PR, I would love feedback on what could be better. I'm not sure if my patterns are the best. |
|
I added another test case to make sure that a specified webpack configuration file with multiple exports will throw an error |
|
Ran |
|
Ran |
| webpack_config = "webpack.worker.js" | ||
| "#}; | ||
|
|
||
| build_fails_with(fixture, "Multiple webpack configurations are not supported. You can specify a different path for your webpack configuration file in wrangler.toml with the `webpack_config` field"); |
There was a problem hiding this comment.
long term... testing on the full error message might make this test a little brittle. i think it's totally fine to keep now, but if we find the error message changes slightly a lot over time... we may just want to test that the error message contains some keywords that we know won't change and are enough to identify it :)
| let webpack_config_path = PathBuf::from( | ||
| &project | ||
| .webpack_config | ||
| .clone() |
There was a problem hiding this comment.
ideally we can avoid clones but sometimes it's not ideal for code readability :) that being said i think this is fine for now, we should just audit these generally
There was a problem hiding this comment.
Yeah I didn't really like it, just what the compiler recommended. I'm still a little iffy on how Rust handles borrowing + what is idiomatic.
|
@EverlastingBugstopper do you think you'd be able to work with @victoriabernard92 + @signalnerve to make a small template that demonstrates using a user created webpack config? i think it'd be great to release this alongside an example |
|
@ashleygwilliams Yeah I could do that. Would that be a part of this PR or separate? |
|
@EverlastingBugstopper let's do it in a different one! landing this now :) |
Fixes #246
This PR allows wrangler to work with projects like this one: https://github.com/jrf0110/cf-workers-boilerplate