This repository has been archived by the owner on Aug 3, 2023. It is now read-only.
Improve version checking for --openssl-legacy-provider #2241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petebacondarwin
approved these changes
Apr 21, 2022
|
I don't think we have tests on this, so let's just merge it, looks good. Thank you @EatonZ for the PR! We'll get a release out very soon. |
|
This is now live in 1.19.12 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node v18 came out yesterday and I noticed that the issue I reported last year returned. I quickly identified the problem and here is a patch for it. Instead of only checking for v17, it will now check for versions higher than that as well, ensuring the issue does not return again when Node v19 releases.
Note: This will stop working again when Node v100 releases. I expect Wrangler v1 to be fully replaced by v2 by that point.
If you approve of this fix, I would greatly appreciate a hotfix update as soon as you are able to release one.