This repository has been archived by the owner on Aug 3, 2023. It is now read-only.
hotfix for expiring unused sites assets #2226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jspspike
approved these changes
Mar 21, 2022
| @@ -20,6 +20,8 @@ use crate::terminal::emoji; | |||
| use crate::terminal::message::{Message, Output, StdErr, StdOut}; | |||
| use crate::upload; | |||
|
|
|||
| const FIVE_MINUTES: Option<i64> = Some(60 * 5); | |||
There was a problem hiding this comment.
nit: Maybe just move this inline where it's used. Since it's not used anywhere else
There was a problem hiding this comment.
ah i kind of like that it has a name, it's more clear than Some(300) imo
caass
pushed a commit
that referenced
this pull request
Mar 22, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2224