This repository has been archived by the owner on Aug 3, 2023. It is now read-only.
Upload .well-known files using default ignore override #1631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ObsidianMinor
force-pushed
the
fix/now-you-have-two-problems
branch
from
e734ce4 to
57d6cbd
Compare
ObsidianMinor
force-pushed
the
fix/now-you-have-two-problems
branch
from
57d6cbd to
ecec43c
Compare
|
@ObsidianMinor, thanks for fixing this. Re Adding a |
nataliescottdavidson
approved these changes
Nov 2, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes all standard filters and replaces the faulty regex hack with a new default override that is used on top of any specified excludes.
Also this is getting more complex than it should be. Can we just use
.gitignoreor.ignorefiles on top ofinclude/excludeand get rid of default "removed items" like node_modules and hidden files? Maybe just add a warning or add an option to preview a publish to see what would be uploaded?