RFC: KV put with metadata

[ags799]

💡 Feature request

Perform a KV put with metadata from Wrangler:

wrangler kv:key put my-key my-value --metadata '{"some": "json"}'

Any kind of JSON works:

• boolean
• number
• object
• array
• strings

[xtuc]

accept almost any kind of JSON [...] not strings though

does it mean

wrangler kv:key put my-key my-value --metadata '1'

is supported but not

wrangler kv:key put my-key my-value --metadata '"json"'

[ags799]

Yes.

…

On Mon, Jan 18, 2021 at 4:05 AM Sven Sauleau ***@***.***> wrote: accept almost any kind of JSON [...] not strings though does it mean wrangler kv:key put my-key my-value --metadata '1' is supported but not wrangler kv:key put my-key my-value --metadata '"json"' — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#1734 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAWSCDLSKRKQXCDPWHPJ4DDS2QBV3ANCNFSM4WEPLAPQ> .

[koeninger]

Why? Doing e.g. the following from a worker is fine:

    await NS.put(key, value, {metadata: "some_string"})

[koeninger]

the third argument isn't metadata, it's an options object that may contain a metadata key. See https://developers.cloudflare.com/workers/runtime-apis/kv#metadata and https://github.com/cloudflare/workers-types/blob/master/index.d.ts#L610

My example above would result in

    const { value, metadata } = await NS.getWithMetadata(key);

binding metadata to "some_string", not {metadata: "some_string"}

[xtuc]

Indeed, thanks for clarify. I hidden my comment since it's not relevant

[ags799]

Why? Doing e.g. the following from a worker is fine:

    await NS.put(key, value, {metadata: "some_string"})

Never mind, I wasn't escaping quotes correctly in my curl command. The API will accept strings just fine.