Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: login / logout / refresh token blows away error_tracking_opt #460

Closed
threepointone opened this issue Feb 14, 2022 · 3 comments · Fixed by #474
Closed

fix: login / logout / refresh token blows away error_tracking_opt #460

threepointone opened this issue Feb 14, 2022 · 3 comments · Fixed by #474
Assignees

Comments

@threepointone
Copy link
Contributor

In user.tsx, whenever we login / logout / refresh the oauth_token, we blow away the error tracking fields error_tracking_opt/error_tracking_opt_date. We should preserve this info.

@petebacondarwin
Copy link
Contributor

Ahah! I was wondering why I kept getting asked the question.
My recommendation was actually to use a completely different file for tracking error reporting settings, rather than trying to share it with the default config one.

@threepointone
Copy link
Contributor Author

That would work! A separate file is a good solution.

@JacobMGEvans
Copy link
Contributor

Ahah! I was wondering why I kept getting asked the question. My recommendation was actually to use a completely different file for tracking error reporting settings, rather than trying to share it with the default config one.

I should have listened the first time you suggested it 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants