Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements Verifiable modes: VOPRF and POPRF #9

Merged
merged 4 commits into from
Mar 24, 2022

Conversation

armfazh
Copy link
Contributor

@armfazh armfazh commented Mar 18, 2022

Test vectors from draft-v09 are passing, except for batched vectors.

@armfazh armfazh requested a review from chris-wood March 18, 2022 23:56
@armfazh armfazh self-assigned this Mar 18, 2022
@lukevalenta
Copy link
Contributor

Should this be rebased on #8 after that's merged?

@armfazh
Copy link
Contributor Author

armfazh commented Mar 21, 2022

rebased now

Copy link
Contributor

@lukevalenta lukevalenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

})
if (testVector.mode === Oprf.Mode.POPRF) {
const info = fromHex((vi as any).Info as string) // eslint-disable-line @typescript-eslint/no-explicit-any
;(server as wrapPOPRFServer).info = info
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First time seeing this syntax--neat!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the colon is to separate conflicting statements.
the other part is just a cast.

src/client.ts Outdated Show resolved Hide resolved
src/server.ts Outdated Show resolved Hide resolved
Co-authored-by: Luke Valenta <lvalenta@cloudflare.com>
src/client.ts Outdated Show resolved Hide resolved
Co-authored-by: Luke Valenta <lvalenta@cloudflare.com>
@armfazh armfazh merged commit df37fa8 into cloudflare:main Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants