Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds module for dleq proofs #8

Merged
merged 2 commits into from
Mar 23, 2022
Merged

adds module for dleq proofs #8

merged 2 commits into from
Mar 23, 2022

Conversation

armfazh
Copy link
Contributor

@armfazh armfazh commented Mar 18, 2022

Add DLEQ proofs of knowledge.

@armfazh armfazh self-assigned this Mar 18, 2022
Copy link
Contributor

@lukevalenta lukevalenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed that the implementation matches https://www.ietf.org/id/draft-irtf-cfrg-voprf-09.html#name-discrete-log-equivalence-pr (and also read https://blog.cloudflare.com/privacy-pass-the-math/ for some additional context).

The code itself LGTM, but there's no documentation. Adding some comments describing how the functions translate to the draft specification would be helpful. I'll leave some comments inline with more detailed suggestions.

src/dleq.ts Outdated Show resolved Hide resolved
src/dleq.ts Outdated Show resolved Hide resolved
src/dleq.ts Outdated Show resolved Hide resolved
src/dleq.ts Outdated Show resolved Hide resolved
src/dleq.ts Outdated Show resolved Hide resolved
Co-authored-by: Luke Valenta <lvalenta@cloudflare.com>
Copy link

@cdrubin cdrubin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a link to the paper and page or similar where many of these symbols names come from so that variables like M, Z and Ci, Di have context.

@armfazh
Copy link
Contributor Author

armfazh commented Mar 23, 2022

Please add a link to the paper and page or similar where many of these symbols names come from so that variables like M, Z and Ci, Di have context.

This was covered by documentation comments added by Luke pointing to the draft's URL.

@armfazh armfazh merged commit da26e28 into cloudflare:main Mar 23, 2022
@armfazh armfazh deleted the dleqProofs branch March 23, 2022 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants