-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds module for dleq proofs #8
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I confirmed that the implementation matches https://www.ietf.org/id/draft-irtf-cfrg-voprf-09.html#name-discrete-log-equivalence-pr (and also read https://blog.cloudflare.com/privacy-pass-the-math/ for some additional context).
The code itself LGTM, but there's no documentation. Adding some comments describing how the functions translate to the draft specification would be helpful. I'll leave some comments inline with more detailed suggestions.
Co-authored-by: Luke Valenta <lvalenta@cloudflare.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a link to the paper and page or similar where many of these symbols names come from so that variables like M, Z and Ci, Di have context.
This was covered by documentation comments added by Luke pointing to the draft's URL. |
Add DLEQ proofs of knowledge.