Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating SSWU mapping with sqrt_ratio function. #3

Merged
merged 1 commit into from
Mar 29, 2022

Conversation

armfazh
Copy link
Contributor

@armfazh armfazh commented Feb 24, 2022

@armfazh armfazh added the enhancement New feature or request label Feb 24, 2022
@cdrubin
Copy link

cdrubin commented Feb 25, 2022

Is there a reasonable way to resolve the TypeScript warnings about the use of the "Any" type?

@cdrubin
Copy link

cdrubin commented Feb 25, 2022

Can we also update the lint rules for max statements and max lines, 50 and 100 respectively seem reasonable to me!

@lukevalenta
Copy link
Contributor

Looks like this PR now has conflicts and needs to be rebased @armfazh

@armfazh armfazh force-pushed the updateSSWUMethod branch 2 times, most recently from acfe693 to ea8bdcf Compare March 21, 2022 21:22
@armfazh
Copy link
Contributor Author

armfazh commented Mar 21, 2022

rebased now

Copy link
Contributor

@lukevalenta lukevalenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple last comments, but the changes LGTM!

src/group.ts Show resolved Hide resolved
src/group.ts Show resolved Hide resolved
@armfazh armfazh merged commit ed31060 into cloudflare:main Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants