Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ResultInfo to RawResponse #1453

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Add ResultInfo to RawResponse #1453

merged 1 commit into from
Nov 28, 2023

Conversation

adampurser-zendesk
Copy link

@adampurser-zendesk adampurser-zendesk commented Nov 28, 2023 •
edited
Loading

Description

Adding ResultInfo to RawResponse to facilitate pagination when using raw requests with list endpoints.

Has your change been tested?

There are no existing unit tests for Raw() and this change shouldn't impact current functionality.

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented in cloudflare/api-schemas
    and relies on stable APIs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 28, 2023 •
edited
Loading

changelog detected ✅

@adampurser-zendesk adampurser-zendesk force-pushed the add-result-info-to-raw-response branch from 6ce9d88 to 2f6d549 Compare November 28, 2023 17:00
@adampurser-zendesk
Add ResultInfo to RawResponse
cc5972a 
Adding ResultInfo to RawResponse to facilitate pagination when using raw requests with list endpoints.
@adampurser-zendesk adampurser-zendesk force-pushed the add-result-info-to-raw-response branch from 2f6d549 to cc5972a Compare November 28, 2023 17:04
@adampurser-zendesk adampurser-zendesk marked this pull request as ready for review November 28, 2023 17:05
@jacobbednarz jacobbednarz merged commit 0702a65 into cloudflare:master Nov 28, 2023
@github-actions github-actions bot added this to the v0.83.0 milestone Nov 28, 2023
github-actions bot pushed a commit that referenced this pull request Nov 28, 2023
Update CHANGELOG.md for #1453
182ec79
@p-linnane p-linnane mentioned this pull request Dec 6, 2023
Merged
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2023

This functionality has been released in v0.83.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jacobbednarz jacobbednarz Awaiting requested review from jacobbednarz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.83.0
Development

Successfully merging this pull request may close these issues.
2 participants
@adampurser-zendesk @jacobbednarz