Use new DNSListResponse object when paginating #1222
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the reuse of the DNSListResponse object when collating multiple pages of API requests as this was reusing the pointers used for the Proxied field.
Description
Fixes #1221
Move the declaration of the DNSListResponse variable to within the pagination loop to for go to create a new variable on each loop and stop the Proxied pointer of DNS records from being reused. A new variable of lastResultInfo was added outside the loop to allow the return of the ResultsInfo from the last page of the requests.
Has your change been tested?
Updated the TestListDNSRecordsPagination test and associated fixtures to replicate the issue describe in the bug. Test now pulls 2 pages and a total of 5 test records configured to replicate #1221. Test failed before the change and passed afterwards.
All other DNS tests have been run and pass without issue
Types of changes
What sort of change does your code introduce/modify?
Checklist: