Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace the deprecated ioutil package #1116

Merged
merged 2 commits into from
Oct 23, 2022

Conversation

marcozac
Copy link

Hello, 👋

I didn't know whether to file an issue for a small contribution like this one. So, here we are with my first PR here!

Description

It is just replaced the deprecated package ioutil with io.

ioutil.ReadAll -> io.ReadAll
ioutil.Discard -> io.Discard

Has your change been tested?

Only go test -v -race ./....

No new tests since ioutil.ReadAll just returns io.ReadAll and ioutil.Discard is equal to the io one.

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented (api.cloudflare.com or developers.cloudflare.com) and stable APIs.

`ioutil.ReadAll` -> `io.ReadAll`
`ioutil.Discard` -> `io.Discard`
@github-actions
Copy link

github-actions bot commented Oct 21, 2022

changelog detected ✅

@jacobbednarz jacobbednarz merged commit 5933e31 into cloudflare:master Oct 23, 2022
@github-actions github-actions bot added this to the v0.53.0 milestone Oct 23, 2022
@jacobbednarz
Copy link
Member

thanks @marcozac 🥇

github-actions bot pushed a commit that referenced this pull request Oct 23, 2022
@github-actions
Copy link

This functionality has been released in v0.53.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants