Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Pages]: Add binding instructions to remix sites #5120

Merged
merged 13 commits into from
Nov 30, 2022

Conversation

Ekwuno
Copy link
Contributor

@Ekwuno Ekwuno commented Jul 12, 2022

This PR updates adding bindings instructions for Remix projects. Addresses #5094

@Ekwuno Ekwuno added this to the Pages and Workers milestone Jul 12, 2022
@Ekwuno Ekwuno self-assigned this Jul 12, 2022
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jul 12, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8aa2397
Status: ✅  Deploy successful!
Preview URL: https://6f5374c5.cloudflare-docs-7ou.pages.dev
Branch Preview URL: https://update-remix-doc.cloudflare-docs-7ou.pages.dev

View logs

@WalshyDev
Copy link
Member

Can we get an example on how to use the bindings? That's what brought up the initial ticket.

these frameworks all have their own ways to use it and we should document it in here

content/pages/framework-guides/remix.md Outdated Show resolved Hide resolved
content/pages/framework-guides/remix.md Outdated Show resolved Hide resolved
content/pages/framework-guides/remix.md Show resolved Hide resolved
content/pages/framework-guides/remix.md Show resolved Hide resolved
Co-authored-by: Kate Tungusova <70746074+deadlypants1973@users.noreply.github.com>
content/pages/framework-guides/remix.md Outdated Show resolved Hide resolved
content/pages/framework-guides/remix.md Outdated Show resolved Hide resolved
Co-authored-by: Daniel Walsh <walshy@cloudflare.com>
@gitguardian
Copy link

gitguardian bot commented Jul 16, 2022

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id Secret Commit Filename
4092891 Generic High Entropy Secret a27daa1 config.toml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

content/pages/framework-guides/remix.md Outdated Show resolved Hide resolved
content/pages/framework-guides/remix.md Show resolved Hide resolved
@WalshyDev WalshyDev self-requested a review August 3, 2022 15:36
Copy link
Contributor

@deadlypants1973 deadlypants1973 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Needs a DO code example.
  2. Has to be clear on where the binding code goes in Remix directory.

content/pages/framework-guides/remix.md Outdated Show resolved Hide resolved
content/pages/framework-guides/remix.md Outdated Show resolved Hide resolved
Ekwuno and others added 2 commits August 4, 2022 12:35
Co-authored-by: Greg Brimble <gbrimble@cloudflare.com>
Co-authored-by: Kate Tungusova <70746074+deadlypants1973@users.noreply.github.com>
Co-authored-by: Greg Brimble <gbrimble@cloudflare.com>
content/pages/framework-guides/remix.md Outdated Show resolved Hide resolved
content/pages/framework-guides/remix.md Outdated Show resolved Hide resolved
content/pages/framework-guides/remix.md Outdated Show resolved Hide resolved
content/pages/framework-guides/remix.md Outdated Show resolved Hide resolved
PCX and Greg

Co-authored-by: Greg Brimble <gbrimble@cloudflare.com>
@deadlypants1973 deadlypants1973 merged commit 2c5831a into production Nov 30, 2022
@deadlypants1973 deadlypants1973 deleted the update-remix-doc branch November 30, 2022 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants