Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cljr-rename-symbol: Doesn't work with Java 9 #399

Closed
em7 opened this issue Nov 28, 2017 · 2 comments
Closed

cljr-rename-symbol: Doesn't work with Java 9 #399

em7 opened this issue Nov 28, 2017 · 2 comments
Labels
Milestone

Comments

@em7
Copy link

em7 commented Nov 28, 2017

Hello, I saw similar issue here but the solution "make sure you are running the latest versions" unfortunately did not help. I have a clean install of Emacs and all packages are freshly downloaded from melpa. Nonetheless I get this error.

This happens only when run on Java 9. I've tried with Java8_144 and it worked OK.

BTW Guys, thank you! You're doing a great job developing this project!

Expected behavior

When running cljr-rename-symbol command with cursor on a function name (both in a form calling a function or in a defn) I want the function to be renamed and all the calling code updated, assuming I have cider connected/jacked in.

Actual behavior

After I run the command with cursor on a function name, this is displayed in a minibuffer:

To perform this op the project needs to be evaluated.
Analyzing a large project might take a while: hit C-g to abort.
(Set cljr-warn-on-eval to nil to analyze the project without warning)
Do you want to proceed? (y or n) y
Fetching symbol occurrences...
cljr-rename-symbol: Wrong type argument: char-or-string-p, nil

Environment & Version information

clj-refactor.el version information

clj-refactor 2.4.0-SNAPSHOT (package: 20171117.317), refactor-nrepl 2.4.0-SNAPSHOT

CIDER version information

;; CIDER 0.16.0snapshot (package: 20171126.150), nREPL 0.2.12
;; Clojure 1.9.0-RC2, Java 9

Leiningen or Boot version

Leiningen 2.8.1 on Java 9 Java HotSpot(TM) 64-Bit Server VM

Emacs version

GNU Emacs 25.3.1 (x86_64-w64-mingw32) of 2017-09-26

Operating system

Windows 7, 64 bit

@expez expez changed the title cljr-rename-symbol: Wrong type argument: char-or-string-p, nil cljr-rename-symbol: Doesn't work with Java 9 Nov 28, 2017
@expez expez added the bug label Nov 28, 2017
@expez
Copy link
Member

expez commented Nov 28, 2017

Link to issue in the middleware repo: clojure-emacs/refactor-nrepl#206

Probably more people will run into this soon so I think it makes sense to leave this open in both repos.

@benedekfazekas benedekfazekas added this to the 2.3.2 milestone Jan 21, 2018
@clojure-emacs clojure-emacs deleted a comment from MalloZup Mar 15, 2022
@vemv
Copy link
Member

vemv commented Mar 15, 2022

refactor-nrepl >= 3.x.x is certainly support all JDKs.

@vemv vemv closed this as completed Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants