Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for sideloading #3733

Closed
bbatsov opened this issue Aug 15, 2024 · 3 comments
Closed

Remove support for sideloading #3733

bbatsov opened this issue Aug 15, 2024 · 3 comments
Labels
good first issue A simple tasks suitable for first-time contributors maintenance

Comments

@bbatsov
Copy link
Member

bbatsov commented Aug 15, 2024

Sideloading was removed in nREPL 1.3 and we should clean up CIDER's code accordingly. The only open issue is whether to delete both sideloading and add-middleware or only sideloading code, as they are kind of related and add-middleware won't work anyways if we kept it. So, probably we should just kill everything and restore add-middleware if we ever get it to work on nREPL's side. @alexander-yakushev What do you think about this?

@bbatsov bbatsov added good first issue A simple tasks suitable for first-time contributors maintenance labels Aug 15, 2024
@bbatsov
Copy link
Member Author

bbatsov commented Aug 15, 2024

The code in question is mostly here https://github.com/clojure-emacs/cider/blob/master/cider-eval.el#L208

@alexander-yakushev
Copy link
Member

add-middleware still exists in nREPL, but I guess it's of no use here in CIDER without the sideloading. I'd say nixing it and restoring in the future is a reasonable way to go.

@bbatsov
Copy link
Member Author

bbatsov commented Aug 15, 2024

Agreed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue A simple tasks suitable for first-time contributors maintenance
Projects
None yet
Development

No branches or pull requests

2 participants