Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLJS doesn't update type when watch is started on init #3101

Closed
bigodel opened this issue Dec 16, 2021 · 2 comments
Closed

CLJS doesn't update type when watch is started on init #3101

bigodel opened this issue Dec 16, 2021 · 2 comments
Labels

Comments

@bigodel
Copy link

bigodel commented Dec 16, 2021

Given a Leiningen project with the following configuration

:repl-options {:init (shadow.cljs.devtools.api/watch :app)}

Starting it with cider-jack-in-clj&cljs, using lein with default parameters and either shadow or shadow-select (doesn't really matter the choice here) as cider-default-cljs-repl, doesn't set the correct cider-repl-type for the CLJS REPL. However, setting it manually via cider-set-repl-type everything works as expected. This sounds oddly familiar to #2305, but I'm not sure if it is related or not to the solution.

Expected behavior

Both REPLs are initialized with the correct cider-repl-type.

Actual behavior

The CLJS REPL remains with cider-repl-type as clj.

Steps to reproduce the problem

Unfortunately, I can't provide with a sample project ATM, but it would suffice to

  1. Have any dummy project with a shadow-cljs build and some Clojure code;
  2. Put the watch call from shadow.cljs.devtools.api anywhere (by this I mean in any form/function specified there) within the :init option under :repl-options;
  3. Start CIDER with cider-jack-in-clj&cljs;
  4. Select lein as a build tool, and either shadow-select or shadow as the CLJS REPL. Finally, choose the build for the CLJS specified in shadow-cljs.edn.

Environment & Version information

CIDER version information

;; CIDER 1.2.0snapshot (package: 20211215.925), nREPL 0.9.0-beta5
;; Clojure 1.10.1, Java 16.0.2

Lein/Boot version

Leiningen 2.9.8 on Java 16.0.2 OpenJDK 64-Bit Server VM

Emacs version

GNU Emacs 28.0.90 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.30, cairo version 1.17.4) of 2021-12-15

Operating system

Arch Linux x86_64, kernel v5.15.7-arch1-1

@stale
Copy link

stale bot commented Mar 30, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribution and understanding!

@stale stale bot added the stale label Mar 30, 2022
@stale
Copy link

stale bot commented Apr 29, 2022

This issues been automatically closed due to lack of activity. Feel free to re-open it if you ever come back to it.

@stale stale bot closed this as completed Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant