Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

End of buffer error after test failure #1143

Closed
AshtonKem opened this issue Jun 19, 2015 · 6 comments
Closed

End of buffer error after test failure #1143

AshtonKem opened this issue Jun 19, 2015 · 6 comments
Labels

Comments

@AshtonKem
Copy link

Steps to reproduce

  1. Find a testing namespace
  2. Eval NS
  3. Run all tests (success)
  4. Run individual test (success)
  5. Edit a test to fail.
  6. Run all tests (failure correctly reported)
  7. Run failing test individually (End of buffer error)
  8. Run all tests (End of buffer error).

After repeating this process, the only way to return to successful tests is to restart Cider.

@bbatsov
Copy link
Member

bbatsov commented Jun 20, 2015

I'm guessing this happens on 0.9.0, right?

@bbatsov bbatsov added the bug label Jun 20, 2015
@bbatsov
Copy link
Member

bbatsov commented Jun 20, 2015

I can't reproduce this with a simple project created with lein new and the following tests in it:

(deftest a-test
  (testing "something"
    (is (= 1 1))))

(deftest b-test
  (testing "something else"
    (is (= 1 1))))

@AshtonKem
Copy link
Author

Correct.

Ashton

Sent from my iPhone

On Jun 20, 2015, at 12:45 AM, Bozhidar Batsov notifications@github.com wrote:

I'm guessing this happens on 0.9.0, right?


Reply to this email directly or view it on GitHub.

@bbatsov
Copy link
Member

bbatsov commented Jun 20, 2015

Can you cook some minimal project in which the problem can be reproduced?

@weejulius
Copy link

steps to reproduce:

load from file and run tests, it works correctly.
and then load the test form again and run tests, you will see the error.

by the way , the souce code and test code is in the same file in my case.

@bbatsov
Copy link
Member

bbatsov commented Jun 20, 2015

@weejulius Yep, that did it. The problem is that when you're doing interactive evaluation the location metadata for the form is not set and this causes this error. There's nothing I can do about the location metadata and I'd advise everyone affected by this to ask @cemerick to merge the patch attached to http://dev.clojure.org/jira/browse/NREPL-59

I can, however, figure out some way to show a nicer message.

Here's some background info about the problem and why this was changed in CIDER 0.9 - #1088.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants