Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Weird test failures #678

Closed
bbatsov opened this issue Jun 16, 2020 · 7 comments
Closed

Weird test failures #678

bbatsov opened this issue Jun 16, 2020 · 7 comments
Labels
good first issue help needed

Comments

@bbatsov
Copy link
Member

bbatsov commented Jun 16, 2020 •
edited
Loading

After ed79316 the build started failing in a really weird way (like ClojureScript/Piggieback's missing). I can't see any connection between disabling suitable and the failure's, though.
@bbatsov
Copy link
Member Author

bbatsov commented Jul 12, 2020

@arichiardi Any idea what might be causing this?

@arichiardi
Copy link
Contributor

I knew suitable has some shadow-specific parts, not really in the meta/info part...it smells like the possible problem but I will definitely take a look when I have some time.

@bbatsov
Copy link
Member Author

bbatsov commented Jul 12, 2020

I'm just not sure those failures are even related to suitable. Anyways, any help would be welcome!

@bbatsov bbatsov mentioned this issue Nov 23, 2020
Merged
@bbatsov
Copy link
Member Author

bbatsov commented Nov 25, 2020

@clojure-emacs/cider Any ideas from anyone? Sorry about the ping, but I just came back to this ticket and I still can't figure out what broke everything cljs-related. It's like in the tests Piggieback doesn't run at all.

@bbatsov bbatsov mentioned this issue Apr 5, 2021
Closed
@bbatsov
Copy link
Member Author

bbatsov commented Apr 5, 2021

Fixed in #691. Turns out it was suitable indeed.

@vemv
Copy link
Member

vemv commented Aug 9, 2021

Issue good to close?

@bbatsov bbatsov closed this as completed Aug 10, 2021
@bbatsov
Copy link
Member Author

bbatsov commented Aug 10, 2021

Indeed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue help needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bbatsov @vemv @arichiardi