From c1bf1ae02bde5a0462dc0b5614f8acb1d88fefaf Mon Sep 17 00:00:00 2001 From: Dustin Swales Date: Tue, 18 Feb 2020 11:57:44 -0700 Subject: [PATCH] Try using 1D hprime --- physics/GFS_rrtmgp_sw_pre.F90 | 4 ++-- physics/GFS_rrtmgp_sw_pre.meta | 8 ++++---- physics/rrtmgp_lw_pre.F90 | 4 ++-- physics/rrtmgp_lw_pre.meta | 8 ++++---- 4 files changed, 12 insertions(+), 12 deletions(-) diff --git a/physics/GFS_rrtmgp_sw_pre.F90 b/physics/GFS_rrtmgp_sw_pre.F90 index 0900b0004..8fc126392 100644 --- a/physics/GFS_rrtmgp_sw_pre.F90 +++ b/physics/GFS_rrtmgp_sw_pre.F90 @@ -69,7 +69,7 @@ subroutine GFS_rrtmgp_sw_pre_run(doLWrad, do_sfcperts, ncol, nlev, ntrac, nsfcpe facwf, & ! Fractional coverage with weak cosz dependency fice, & ! Ice fraction over open water tisfc ! Sea ice surface skin temperature - real(kind_phys), dimension(ncol,nmtvr), intent(in) :: & + real(kind_phys), dimension(ncol), intent(in) :: & hprime ! orographic metrics real(kind_phys), dimension(ncol,nlev),intent(in) :: & p_lay, & ! Layer pressure @@ -147,7 +147,7 @@ subroutine GFS_rrtmgp_sw_pre_run(doLWrad, do_sfcperts, ncol, nlev, ntrac, nsfcpe ! ####################################################################################### ! Call module_radiation_surface::setalb() to setup surface albedo. ! ####################################################################################### - call setalb (slmsk, snowd, sncovr, snoalb, zorl, coszen, tsfc, tsfc, hprime(:,1), alvsf, & + call setalb (slmsk, snowd, sncovr, snoalb, zorl, coszen, tsfc, tsfc, hprime, alvsf, & alnsf, alvwf, alnwf, facsf, facwf, fice, tisfc, NCOL, alb1d, pertalb, sfcalb) ! Approximate mean surface albedo from vis- and nir- diffuse values. diff --git a/physics/GFS_rrtmgp_sw_pre.meta b/physics/GFS_rrtmgp_sw_pre.meta index e4b1944d1..453c12de2 100644 --- a/physics/GFS_rrtmgp_sw_pre.meta +++ b/physics/GFS_rrtmgp_sw_pre.meta @@ -165,10 +165,10 @@ intent = in optional = F [hprime] - standard_name = statistical_measures_of_subgrid_orography - long_name = orographic metrics - units = various - dimensions = (horizontal_dimension,number_of_statistical_measures_of_subgrid_orography) + standard_name = standard_deviation_of_subgrid_orography + long_name = standard deviation of subgrid orography + units = m + dimensions = (horizontal_dimension) type = real kind = kind_phys intent = in diff --git a/physics/rrtmgp_lw_pre.F90 b/physics/rrtmgp_lw_pre.F90 index a55a6657e..9cb84dc0d 100644 --- a/physics/rrtmgp_lw_pre.F90 +++ b/physics/rrtmgp_lw_pre.F90 @@ -46,7 +46,7 @@ subroutine rrtmgp_lw_pre_run (doLWrad, nCol, lon, lat, lsmask, zorl, snowd, snco snowd, & ! water equivalent snow depth (mm) sncovr, & ! Surface snow are fraction (1) tsfc ! Surface skin temperature (K) - real(kind_phys), dimension(nCol,nmtvr), intent(in) :: & + real(kind_phys), dimension(nCol), intent(in) :: & hprime ! Standard deviation of subgrid orography type(ty_gas_optics_rrtmgp),intent(in) :: & @@ -72,7 +72,7 @@ subroutine rrtmgp_lw_pre_run (doLWrad, nCol, lon, lat, lsmask, zorl, snowd, snco ! ####################################################################################### ! Call module_radiation_surface::setemis(),to setup surface emissivity for LW radiation. ! ####################################################################################### - call setemis (lon, lat, lsmask, snowd, sncovr, zorl, tsfc, tsfc, hprime(:,1), nCol, sfc_emiss) + call setemis (lon, lat, lsmask, snowd, sncovr, zorl, tsfc, tsfc, hprime, nCol, sfc_emiss) ! Assign same emissivity to all bands do iBand=1,lw_gas_props%get_nband() diff --git a/physics/rrtmgp_lw_pre.meta b/physics/rrtmgp_lw_pre.meta index 86b4d3e36..cc3369f3b 100644 --- a/physics/rrtmgp_lw_pre.meta +++ b/physics/rrtmgp_lw_pre.meta @@ -89,10 +89,10 @@ intent = in optional = F [hprime] - standard_name = statistical_measures_of_subgrid_orography - long_name = orographic metrics - units = various - dimensions = (horizontal_dimension,number_of_statistical_measures_of_subgrid_orography) + standard_name = standard_deviation_of_subgrid_orography + long_name = standard deviation of subgrid orography + units = m + dimensions = (horizontal_dimension) type = real kind = kind_phys intent = in