Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rethink publishing cycle #84

Open
lewisjared opened this issue Feb 15, 2023 · 2 comments
Open

Rethink publishing cycle #84

lewisjared opened this issue Feb 15, 2023 · 2 comments
Labels
feature Related to a (new) feature

Comments

@lewisjared
Copy link
Contributor

The problem

Currently users publish data before pushing to CI which seems out of order.

Users should ensure tests pass before publishing.

Definition of "done"

  • Think about a best practise approach to ensuring notebooks run successfully before publishing
  • Document this process
  • Update CI to reflect these changes

Additional context

Perhaps the notebook testing should be published on merge by the CI?

@lewisjared
Copy link
Contributor Author

The current testing framework needs a rethink as well. It doesn't really test anything other than the notebook produces a reproducible result

@lewisjared
Copy link
Contributor Author

I believe that this is resolved when migrating to new dataset repositories as the publish process doesn't happen at the MR level, instead via version bumps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Related to a (new) feature
Projects
None yet
Development

No branches or pull requests

1 participant