Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The "Import Data" button is using a browser-specific styling workaround #39

Open
FifthTundraG opened this issue Nov 25, 2024 · 0 comments
Labels
bug Something isn't working release Does this affect the release branch?

Comments

@FifthTundraG
Copy link
Collaborator

FifthTundraG commented Nov 25, 2024

The "Import Data" button is not actually a button, it's an input element. Input elements cannot look like buttons. So, as a workaround, I decided to make a label for the input element that had all the CSS styling of a button. On Chrome, it works perfectly, you can't even tell it's not a real button.

The issue?

What if you're not using Chrome?

Uh oh.

See some screenshots below of how it looks on other browsers:

image

Safari:
image

What do we do about this?

There's three options: figure out how to make input elements into button elements, somehow convert the functionality of the "Import Data" input to something that works with a button element, or the least ideal one: creating our own styles for the buttons and not just using the browser default.

Or just leaving it as-is and hating it forever 🤷

@FifthTundraG FifthTundraG added the bug Something isn't working label Nov 25, 2024
@FifthTundraG FifthTundraG added the release Does this affect the release branch? label Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working release Does this affect the release branch?
Projects
None yet
Development

No branches or pull requests

1 participant