Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add options to advanced popups #32

Open
FifthTundraG opened this issue Jul 9, 2024 · 0 comments
Open

Add options to advanced popups #32

FifthTundraG opened this issue Jul 9, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@FifthTundraG
Copy link
Collaborator

Advanced popups are great, but there's a lot you can't do with them. One thing that annoys me about them is that you can't add padding to the popup without doing a bunch of gymnastics with JS. Another thing that I recently thought would be a beneficial addition would be to be able to change the level of filter that appears when the popup is present (idk if this is actually possible or not). Then there's also the filter parameter that was removed, but for a time I've been planning on re-implementing it. With this many ideas for how to configure the functionality of an advanced popup, we'll very quickly start stacking massive amounts of parameters on the helper.popup.createAdvanced() function. To fix this, I propose that we have only one parameter, options, that will be an object containing various configuration options for the popup. Here is an example of the interface for this object:

interface AdvancedPopupOptions {
    showFilter: boolean;
    filterLevel: number;
    innerPadding: number;
}
@FifthTundraG FifthTundraG added the enhancement New feature or request label Jul 9, 2024
@FifthTundraG FifthTundraG added this to the 0.7 milestone Jul 9, 2024
@FifthTundraG FifthTundraG self-assigned this Jul 9, 2024
@FifthTundraG FifthTundraG added this to Todo Jul 9, 2024
@FifthTundraG FifthTundraG moved this to Todo in Todo Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Todo
Development

No branches or pull requests

1 participant