fix(clerk-js): Avoid triggering email code verification twice on React strict mode #5095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c35b8ee The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
LauraBeatris
force-pushed
the
laura/sdk-1964-email-for-sign-in-with-email_code-gets-triggered-twice-when
branch
from
663b1d4 to
7d33778
Compare
LauraBeatris
force-pushed
the
laura/sdk-1964-email-for-sign-in-with-email_code-gets-triggered-twice-when
branch
from
7d33778 to
1bad83b
Compare
panteliselef
requested changes
Feb 7, 2025
Comment on lines
65
to
68
| { | ||
| name: 'prepare', | ||
| strategy: props.factor.strategy, | ||
| }, |
There was a problem hiding this comment.
- Let's use a more specific name for the cache key
- If you go back to start and use a different identifier (email) it would not auto-prepare on render.
Suggested change
| { | |
| name: 'prepare', | |
| strategy: props.factor.strategy, | |
| }, | |
| { | |
| name: 'signIn.prepareFirstFactor', | |
| factor: props.factor, | |
| }, |
There was a problem hiding this comment.
I've updated it here: 2c03905
The behavior now is the following: It'll cache for a given identifier, so if you go back to /sign-in and submit again, it won't send another email cause it's cached - I've added a smaller stale time for that reason, unless you click to "Resend"
When refreshing the page, it'll only fetch once instead of twice (previous bug)
LauraBeatris
force-pushed
the
laura/sdk-1964-email-for-sign-in-with-email_code-gets-triggered-twice-when
branch
from
1bad83b to
732df87
Compare
LauraBeatris
force-pushed
the
laura/sdk-1964-email-for-sign-in-with-email_code-gets-triggered-twice-when
branch
from
2c03905 to
4c9858e
Compare
panteliselef
approved these changes
Feb 7, 2025
LauraBeatris
deleted the
laura/sdk-1964-email-for-sign-in-with-email_code-gets-triggered-twice-when
branch
wobsoriano
pushed a commit
that referenced
this pull request
Feb 8, 2025
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before
CleanShot.2025-02-06.at.15.28.13.mp4
After
CleanShot.2025-02-06.at.15.29.02.mp4
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change