fix: workaround LiveRegion layout issues #1534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See https://static.duvallj.pw/2024-11-19/scrollHeightBug/index.html for a reproduction, and https://blog.duvallj.pw/posts/2024-11-19-chrome-heisenbug-uncovered.html for an explanation
🦋 Changeset detectedLatest commit: fd5b2e6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
clauderic
approved these changes
Nov 23, 2024
This was referenced Nov 23, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out, under some sufficiently complex CSS conditions, the visually hidden
<LiveRegion>component can cause layout issues. See https://static.duvallj.pw/2024-11-19/scrollHeightBug/index.html for a minimal reproduction (Chrome and Firefox; behavior is correct in Safari), and https://blog.duvallj.pw/posts/2024-11-19-chrome-heisenbug-uncovered.html for an explanation of what's wrong about this example.TL;DR sometimes this
position: fixed;element will overflow container divs in a strange + unexpected + buggy way. Setting explicittop/leftproperties causes the layout to be calculated correctly again.