Use aria-live="polite" for announcements
#1229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: df9c335 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@clauderic just wanted to bring this to your attention. Really appreciate you and this library, thank you so much. |
hussam-i-am
reviewed
Oct 27, 2023
| }; | ||
|
|
||
| export function LiveRegion({id, announcement}: Props) { | ||
| export function LiveRegion({id, announcement, ariaLiveType = "polite"}: Props) { |
There was a problem hiding this comment.
@ayy-bc Maybe we should keep this defaulted to assertive so it doesnt affect any existing usages
There was a problem hiding this comment.
I think defaulting to assertive would be the way to go!
|
@ayy-bc Also, can you add a changeset to this? Thanks! |
clauderic
approved these changes
Nov 6, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When playing around with dnd-kit, I noticed that the
aria-liveproperty is set to "assertive" by default. I believe that "assertive" should only be used for time-sensitive/critical notifications that absolutely require the user's immediate attention (from: https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/ARIA_Live_Regions#live_regions).Also, changing it to "polite" makes it such that the announcement is made when the user is idle. I think that really helps with screen-reader not announcing each time a user moves the item (gets a little annoying when say I want to drag it 5 rows below, it keeps announcing for each row but doesn't complete the announcement as each time I press down, it announces the new position without the last one completing) and instead, announces it when the user is a little sure of where the item should be (i.e be idle).
Also moved the
visuallyHiddendirectly within the component and not as a global constant as this reduces the number of declared constants and limits the scope of visuallyHidden (since it is only used withinLiveRegionanyways)