Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making optional spec.networkProfile.domain and renaming it to certSANs #59

Closed
prometherion opened this issue Jun 15, 2022 Discussed in #48 · 0 comments · Fixed by #75
Closed

Making optional spec.networkProfile.domain and renaming it to certSANs #59

prometherion opened this issue Jun 15, 2022 Discussed in #48 · 0 comments · Fixed by #75
Assignees
Labels
enhancement New feature or request helm Changes addresses in the Helm chart
Milestone

Comments

@prometherion
Copy link
Member

Discussed in #48

Originally posted by prometherion May 31, 2022

We know that Kamaji could be exposed in several ways, from dynamic Load Balancer to bare IP or Ingress resources.

In the latter case, we already support the required hostname to perform host matching, as well as generate the certificate required for it.

However, in some circumstances, we could have a LoadBalancer reachable through a DNS, and suddenly, by a hostname that is not reported in any Kubernetes primitive.

With that said, we could add the new array of strings named certSANs with the following default values:

  1. localhost
  2. 127.0.0.1
  3. 0.0.0.0

With such an option, an operator can easily add an arbitrary hostname, without worrying about the IP address or Ingress hostname used to expose the Tenant Control Plane since it's already covered by Kamaji.

@prometherion prometherion added the enhancement New feature or request label Jun 15, 2022
@prometherion prometherion added this to the v0.0.2 milestone Jun 15, 2022
@prometherion prometherion self-assigned this Jun 15, 2022
@prometherion prometherion added the helm Changes addresses in the Helm chart label Jul 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request helm Changes addresses in the Helm chart
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant