-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changelog doesn't mention a number of deprecations #3495
Comments
This was covered by a catch-all item
That is a lot to individually specify and it didn't seem like much value since the compiler will tell people about these. |
How are For example, how would I translate this to something that doesn't use deprecated functions? Are they not allowed unless the builder method is used instead? #[derive(Parser, Default, Clone, Debug, PartialEq)]
#[clap(
version = crate_version!(),
author = <String as AsRef<str>>::as_ref(&APP_AUTHORS),
about = <String as AsRef<str>>::as_ref(&APP_ABOUT),
after_help = <String as AsRef<str>>::as_ref(&AFTER_HELP),
override_usage = <String as AsRef<str>>::as_ref(&OVERRIDE_HELP),
max_term_width(100),
color(clap::ColorChoice::Auto),
global_setting(AppSettings::DeriveDisplayOrder),
global_setting(AppSettings::InferSubcommands),
global_setting(AppSettings::InferLongArgs),
global_setting(AppSettings::DisableHelpSubcommand),
global_setting(AppSettings::DontCollapseArgsInUsage),
global_setting(AppSettings::UseLongFormatForHelpSubcommand),
)]
pub(crate) struct Opts {} |
Note that the following are builder methods:
So when it suggests to replace
with
|
Ah, I see. I didn't realize that all the builder commands were translated like that. Thank you for the clarification! |
Please complete the following tasks
Rust Version
rustc 1.58.1 (db9d1b20b 2022-01-20)
Clap Version
3.1.1
Minimal reproducible code
Code using
ArgSettings::AllowInvalidUtf8
,AppSettings::ArgRequiredElseHelp
,AppSettings::DontCollapseArgsInUsage
orAppSettings::SubcommandRequired
.Steps to reproduce the bug with the above code
Compile aforementioned code
Actual Behaviour
Deprecation warnings are displayed such as:
Expected Behaviour
CHANGELOG should contain something about these deprecations but AFAICT, doesn't.
Additional Context
The above may be non-exhaustive. This is the result of existing code that builds with no warning with clap 3.0 having been updated to 3.1. There may have been more deprecations that aren't documented in the changelog.
Debug Output
No response
The text was updated successfully, but these errors were encountered: