Typing over the link feature

[pomek]

Suggested merge commit message (convention)

Feature (link): Typing over the selected link will not remove the link itself. Instead, the typed text will replace the link text. Closes #4762.

[pomek]

@ckeditor/qa-team, could you check how the solution works with CF?

[Mgsy]

It works fine 👌  We've tested it in all browser and on mobiles.

[jodator]

The check for feature activation (so a whole link and only link is selected) needs improvement.

[Reinmar]

cc @scofalik I think you should know about this change as it touches the very fragile typing/insert/delete content.

[Reinmar]

Just to be sure:

• Does this PR also change the behavior at the beginning of the link? It should, as it was part of the issue too.
• Does it affect pasting and other forms of inserting content other than typing? It should not, as we only want to affect typing.

[scofalik]

At first sight, it looks like the change should be safe for track changes:

• deleteContent callback does not modify anything. If I correctly imagine what will happen, this should work just fine.
• insertContent callback, AFAICS, just adds some attributes to the model that hasn't been inserted yet:
  • this callback and track change's callback have the same priority,
  • if this callback is fired before track change's callback, track changes will never know that something happened,
  • if it is fired after it, AFAICS from the execution flow, the new callback will be fired anyway (track change's callback eventually fires insertContent too and your callback should be executed then).

This needs testing, but as I said, as I look at it now, it should be fine.

[pomek]

Guys, I've just pushed fixes. Could you check the feature once again?

cc: @jodator, @scofalik @ckeditor/qa-team

[jodator]

@pomek  for pasting and basic link integration - now it works nice with the typing detection 👍

The only thing left is my previous comment: #7590 (comment). In case of multiple other attributes over a link. It is kinda corner case but IMO we could treat it as typing over a link.

[pomek]

@jodator, should I write additional test for such case? In the code, we copy the selection's attributes.

[jodator]

Yes, please :) I think that something like below (sample is without values) should work (three text nodes):

foo [<$text linkHref>b</$text><$text linkHref bold>a</$text><$text linkHref>r</$text>] baz

after type "box":

foo <$text linkHref>box[]</$text> baz

[FilipTokarski]

Checked in all browsers and apart from the case with attributes, it looks ok 👍

[pomek]

@jodator, done. Ready for review once again. I hope, it will be the last one.