-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
parcel support #986
Comments
Hi! The Advanced setup guide explains the minimal configuration which is needed to build CKEditor 5. It talks about webpack, but these 3 points should help you understand what needs to be configured in general:
I don't know parcel but assuming that it implements some similar mechanism to webpack's loaders, you can easily handle the point about SVG files. The CSS files are a bigger problem. We use PostCSS with a couple of standard plugins. However, we also needed to implement our own custom plugin for it. @oleq will tell you more what it does and whether it's possible to leave without it. Finally, there's localisation. If you want to use CKEditor 5 in English, then you don't need to do anything. If you, however, want to have it localised, then you'd need to port the Please note that unless you want to integrate with CKEditor 5 very closely, there are other methods to include CKEditor 5 into your app. See my comments in #987 (comment). |
It's the theme importer plugin we're talking about. Every single UI component of the editor comes with some CSS. But that's only the wireframe. To make it look like an actual button/dropdown/input, a theme is required. ATM we have only one theme https://github.com/ckeditor/ckeditor5-theme-lark. What the theme importer plugin does is glue the wireframe CSS files with the theme CSS files, that's all. This importer plugin and other PostCSS essentials are wrapped in the At some point, you have to import const { styles } = require( '@ckeditor/ckeditor5-dev-utils' );
...
somePostCssOptions: styles.getPostCssConfig( {
themeImporter: {
themePath: require.resolve( '@ckeditor/ckeditor5-theme-lark' )
},
minify: true
} ) though I'm not sure what does it look like in parcel. It looks like the configuration is in the |
Thanks for your reply. Your explanations are really helpful. |
@ocavue can you share your solution? Thanks. |
@ThaddeusJiang I didn't find out a solution in the end so I switch to webpack. Sorry about that. I will keep this issue open in case someone figures it out in the future. |
@ocavue Thank you very much. |
@ocavue Hi, brother. see: https://github.com/ThaddeusJiang/ckeditor5-build-blueberry |
Just did some work. I found out that parcel can't import I get this error because Maybe parcel-bundler/parcel#329 is related but I'm not sure. |
All those issues will probably be resolved once #15502 hit npm (the project is in progress, all feedback greatly welcomed) |
Issure resolved with |
This issue is a feature request.
It seems that ckeditor 5 only support webpack for now. Does ckeditor have any plan to support parcel?
BTW, if you are interesting to it, there is the error when I try to build ckeditor 5 framework with parcel:
If you'd like to see this issue resolved please react with 👍 to this post.
The text was updated successfully, but these errors were encountered: