Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual test collapse button has no focus indication #7987

Closed
mlewand opened this issue Sep 1, 2020 · 1 comment · Fixed by nextcloud/mail#4753, nextcloud/mail#4757 or xhj/ckeditor5-build-rails#19
Assignees
Labels
intro Good first ticket. package:dev squad:platform Issue to be handled by the Platform team. type:task This issue reports a chore (non-production change) and other types of "todos".

Comments

@mlewand
Copy link
Contributor

mlewand commented Sep 1, 2020

Provide a description of the task

New focus indication has no focus indication. Since it is a button it takes the focus, but doesn't show that.

Below you can see that it can be operated with the keyboard but you wouldn't know that looking just at the screen:

@mlewand mlewand added type:task This issue reports a chore (non-production change) and other types of "todos". squad:platform Issue to be handled by the Platform team. package:dev intro Good first ticket. labels Sep 1, 2020
@mlewand
Copy link
Contributor Author

mlewand commented Sep 1, 2020

It's just a matter of changing

diff --git a/packages/ckeditor5-dev-tests/lib/utils/manual-tests/template.html b/packages/ckeditor5-dev-tests/lib/utils/manual-tests/template.html
index b2ea1034..c3b92586 100644
--- a/packages/ckeditor5-dev-tests/lib/utils/manual-tests/template.html
+++ b/packages/ckeditor5-dev-tests/lib/utils/manual-tests/template.html
@@ -101,12 +101,15 @@
                        border: none;
                        padding: 0;
                        margin: 0;
-                       outline: none;
                        transition: left var(--ck-manual-test-transition-time) ease-in-out;
                        opacity: .5;
                        z-index: 10000;
                }

+               .manual-test-sidebar__toggle:not(:focus) {
+                       outline: none;
+               }
+
                .manual-test-sidebar__toggle:hover {
                        opacity: 1;
                }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment