Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block filler is not removed when converting <pre><code> #7259

Closed
tomalec opened this issue May 21, 2020 · 2 comments
Closed

Block filler is not removed when converting <pre><code> #7259

tomalec opened this issue May 21, 2020 · 2 comments
Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:code-block resolution:expired This issue was closed due to lack of feedback. squad:core Issue to be handled by the Core team. status:stale type:bug This issue reports a buggy (incorrect) behavior.

Comments

@tomalec
Copy link
Contributor

tomalec commented May 21, 2020

This is a follow-up from #7240

📝 Provide detailed reproduction steps (if any)

  1. Open editor with an empty code block.
  2. (optional) Execute editor.getData() // "<pre><code>&nbsp;</code></pre>"
  3. Execute editor.setData( "<pre><code>&nbsp;</code></pre>" )

✔️ Expected result

You should get the editor with an empty code block (, where you cannot move the caret between any characters).

❌ Actual result

The editor is created with one non-breaking space inside code block;

📃 Other details

  • Browser: Chrome, FF
  • OS: Win10
  • CKEditor version: master (@ad227917a6)
  • Installed CKEditor plugins: code-block

Undesired, but expected behavior is covered by this test:

// Undesired by expected. There is an issue with identifying the correct filler type.
// <code> is inline, so dom-to-view converter expects an inline filler.
it( 'should convert pre > code with only &nbsp; inside to a codeBlock with &nbsp;', () => {
editor.setData( '<pre><code>&nbsp;</code></pre>' );
expect( getModelData( model ) ).to.equal(
'<codeBlock language="plaintext">[]\u00a0</codeBlock>'
);
} );

More details, with investigation results at #7240 (comment)


If you'd like to see this fixed sooner, add a 👍 reaction to this post.

@tomalec tomalec added type:bug This issue reports a buggy (incorrect) behavior. package:code-block squad:red labels May 21, 2020
@Reinmar Reinmar added this to the nice-to-have milestone Jun 22, 2020
@Reinmar Reinmar added the domain:ui/ux This issue reports a problem related to UI or UX. label Jun 22, 2020
@Reinmar Reinmar added squad:core Issue to be handled by the Core team. and removed squad:red labels Jul 28, 2020
@pomek pomek removed this from the nice-to-have milestone Feb 21, 2022
@CKEditorBot
Copy link
Collaborator

There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may still be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.

@CKEditorBot
Copy link
Collaborator

We've closed your issue due to inactivity over the last year. We understand that the issue may still be relevant. If so, feel free to open a new one (and link this issue to it).

@CKEditorBot CKEditorBot added the resolution:expired This issue was closed due to lack of feedback. label Nov 13, 2023
@CKEditorBot CKEditorBot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:code-block resolution:expired This issue was closed due to lack of feedback. squad:core Issue to be handled by the Core team. status:stale type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

No branches or pull requests

4 participants