Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

escPressHandler should be replaced by KeystrokeHandler #5306

Closed
oleq opened this issue Jan 25, 2017 · 2 comments
Closed

escPressHandler should be replaced by KeystrokeHandler #5306

oleq opened this issue Jan 25, 2017 · 2 comments
Assignees
@oleq
Labels
package:ui type:task This issue reports a chore (non-production change) and other types of "todos".
Milestone
iteration 12

Comments

@oleq
Copy link
Member

oleq commented Jan 25, 2017

In places like https://github.com/ckeditor/ckeditor5-image/blob/master/src/imagealternatetext/imagealternatetext.js#L105-L109 it should be replaced by an appropriate keystroke handler like https://github.com/ckeditor/ckeditor5-link/blob/master/src/link.js#L178-L184.
@Reinmar
Copy link
Member

Reinmar commented Jan 25, 2017

There's a ticket for the change in the image feature: https://github.com/ckeditor/ckeditor5-image/issues/40.

In this ticket we should remove the escPressHandler and think on how to refactor this code: https://github.com/ckeditor/ckeditor5-link/blob/63e70927751e3652b70375f23c1ff5bf5ba81723/src/link.js#L170-L192. It'll repeat in the image package as well. Perhaps it should be a part of https://github.com/ckeditor/ckeditor5-ui/issues/134.

@oskarwrobel
Copy link
Contributor

escPressHandler is used nowhere. We can remove it.

@oleq oleq self-assigned this Sep 25, 2017
oleq referenced this issue in ckeditor/ckeditor5-ui Sep 28, 2017
@oleq
Other: The escPressHandler function should be replaced by the `Keys…
b322744 
…trokeHandler`. Closes #150.

BREAKING CHANGE: The `escPressHandler` is no longer available. Please
refer to the `KeystrokeHandler` helper to learn more.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-ui Oct 9, 2019
@mlewand mlewand added this to the iteration 12 milestone Oct 9, 2019
@mlewand mlewand added type:task This issue reports a chore (non-production change) and other types of "todos". package:ui labels Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleq oleq

Labels
package:ui type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Milestone
iteration 12
Development

No branches or pull requests
4 participants
@Reinmar @oskarwrobel @oleq @mlewand