Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't execute table property command on opening table property window #13262

Closed
kbinieda opened this issue Jan 13, 2023 · 0 comments · Fixed by #13263
Closed

Don't execute table property command on opening table property window #13262

kbinieda opened this issue Jan 13, 2023 · 0 comments · Fixed by #13263
Assignees
@kbinieda
Labels
package:table squad:collaboration Issue to be handled by the Collaboration team. type:improvement This issue reports a possible enhancement of an existing feature.
Milestone
iteration 60 (v36...

Comments

@kbinieda
Copy link
Contributor

kbinieda commented Jan 13, 2023 •
edited by scofalik
Loading

📝 Provide a description of the improvement

  1. Create a table with 2+ tableCells
  2. Change background (or any property) of one tableCell
  3. Open table cell properties window of second tableCell

The command for changed property in step 2 is called (shouldn't be called before changing any value). This leads to creating unnecessary suggestions in track changes mode.

Note: Same things happen with table and table cells properties.
@kbinieda kbinieda added type:improvement This issue reports a possible enhancement of an existing feature. package:table squad:collaboration Issue to be handled by the Collaboration team. status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. labels Jan 13, 2023
@kbinieda kbinieda self-assigned this Jan 13, 2023
@kbinieda kbinieda mentioned this issue Jan 13, 2023
Merged
@scofalik scofalik changed the title Don't execute table property command on opening table property window. Don't execute table property command on opening table property window Jan 13, 2023
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Jan 16, 2023
@CKEditorBot CKEditorBot added this to the iteration 60 milestone Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kbinieda kbinieda

Labels
package:table squad:collaboration Issue to be handled by the Collaboration team. type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Milestone
iteration 60 (v36.0.0)
Development

Successfully merging a pull request may close this issue.

Other (table): Do not execute property command on table property window open ckeditor/ckeditor5
2 participants
@kbinieda @CKEditorBot