New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ContextualToolbar doesn't normalise the config #5414

Closed

Reinmar opened this issue Sep 30, 2017 · 1 comment

Assignees

Labels

package:ui type:bug

Milestone

Member

Reinmar commented Sep 30, 2017

And it needs to do so because in #572 we made builds use the extended format.

Reinmar self-assigned this

Member Author

Reinmar commented Sep 30, 2017

Also, fillFromConfig() should not be the one handling undefined configs. It's better to normalize them earlier, so in normalizeToolbarConfig().

Reinmar closed this as completed in


      ckeditor/ckeditor5-ui@d71cad8

mlewand transferred this issue from ckeditor/ckeditor5-ui

mlewand added this to the iteration 12 milestone

mlewand added status:confirmed type:bug package:ui labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment