Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The ToolbarView should warn when the factory does not provide a component #5398

Closed
oleq opened this issue Aug 23, 2017 · 0 comments · Fixed by ckeditor/ckeditor5-ui#292
Closed

The ToolbarView should warn when the factory does not provide a component #5398

oleq opened this issue Aug 23, 2017 · 0 comments · Fixed by ckeditor/ckeditor5-ui#292
Assignees
@oleq
Labels
package:ui type:improvement This issue reports a possible enhancement of an existing feature.
Milestone
iteration 12

Comments

@oleq
Copy link
Member

oleq commented Aug 23, 2017

A follow-up of #526.
@oleq oleq self-assigned this Aug 23, 2017
oleq referenced this issue in ckeditor/ckeditor5-ui Aug 23, 2017
@oleq
Other: ToolbarView#fillFromConfig should warn when the factory does n…
cfb95b4 
…ot provide a component. Closes #291.
Reinmar referenced this issue in ckeditor/ckeditor5-ui Sep 12, 2017
@Reinmar
Merge pull request #292 from ckeditor/t/291
2e63e70 
Other: `ToolbarView#fillFromConfig()` will warn when the factory does not provide a component. Closes #291. Closes ckeditor/ckeditor5#526.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-ui Oct 9, 2019
@mlewand mlewand added this to the iteration 12 milestone Oct 9, 2019
@mlewand mlewand added type:improvement This issue reports a possible enhancement of an existing feature. package:ui labels Oct 9, 2019
@oleq oleq mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleq oleq

Labels
package:ui type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Milestone
iteration 12
2 participants
@oleq @mlewand