Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InputTextView can not be added as a child when has no id property or id is a number #5396

Closed
oskarwrobel opened this issue Aug 18, 2017 · 0 comments · Fixed by ckeditor/ckeditor5-ui#290
Closed

InputTextView can not be added as a child when has no id property or id is a number #5396

oskarwrobel opened this issue Aug 18, 2017 · 0 comments · Fixed by ckeditor/ckeditor5-ui#290
Assignees
@pomek
Labels
package:ui type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 11

Comments

@oskarwrobel
Copy link
Contributor

When InputTextView with no id is defined as a child in template then exception is thrown:

CKEditorError: collection-add-invalid-id

This is most probably because of missing custom idProperty:
https://github.com/ckeditor/ckeditor5-ui/blob/b2d9002f5a829cf278c3258cba8336230f04708f/src/template.js#L1084

https://github.com/ckeditor/ckeditor5-ui/blob/b2d9002f5a829cf278c3258cba8336230f04708f/src/viewcollection.js#L29-L31
@pomek pomek self-assigned this Aug 22, 2017
oleq referenced this issue in ckeditor/ckeditor5-ui Aug 23, 2017
@oleq
Merge pull request #290 from ckeditor/t/289
d7072ba 
Fix: The `Template` class should not throw an error when a child view in the definition has an `id` attribute set without a value. Closes #289.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-ui Oct 9, 2019
@mlewand mlewand added this to the iteration 11 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:bug This issue reports a buggy (incorrect) behavior. package:ui labels Oct 9, 2019
@pomek pomek mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pomek pomek

Labels
package:ui type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 11
Development

Successfully merging a pull request may close this issue.

T/289: Changed type of collection used in "Template" class. ckeditor/ckeditor5-ui
3 participants
@oskarwrobel @pomek @mlewand