Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The dropdown menu should not open using the keyboard when disabled #5363

Closed
oleq opened this issue May 26, 2017 · 0 comments · Fixed by ckeditor/ckeditor5-ui#240
Closed

The dropdown menu should not open using the keyboard when disabled #5363

oleq opened this issue May 26, 2017 · 0 comments · Fixed by ckeditor/ckeditor5-ui#240
Assignees
@oleq
Labels
package:ui type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 11

Comments

@oleq
Copy link
Member

oleq commented May 26, 2017

Steps to reproduce

  1. Go to https://ckeditor5.github.io/
  2. Click on an image to make a selection.
  3. Press ALT + F10 to focus a toolbar.
  4. Press move down arrow to open styling tab.
  5. Again press move down arrow to select paragraph styling.
  6. Press Enter.

Current result

Editor crashes.

Expected result

There should not be any possibility to open styling menu while selecting an image.

The original issue is #448.

Possible fix

It's just probably a matter of isEnabled check around here.
oleq referenced this issue in ckeditor/ckeditor5-ui May 30, 2017
@oleq
Fix: The dropdown menu should not open using the keyboard when disabl…
b066f2c 
…ed. Closes #238.
@oleq oleq self-assigned this May 30, 2017
oleq referenced this issue in ckeditor/ckeditor5-ui May 31, 2017
@oleq
Tests: Fixed dropdown test which failed after #238 fix.
fb5511a
szymonkups referenced this issue in ckeditor/ckeditor5-ui Jun 1, 2017
@szymonkups
Merge pull request #240 from ckeditor/t/238
fc524b8 
Fix: The dropdown menu should not open using the keyboard when disabled. Closes #238.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-ui Oct 9, 2019
@mlewand mlewand added this to the iteration 11 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:bug This issue reports a buggy (incorrect) behavior. package:ui labels Oct 9, 2019
@oleq oleq mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleq oleq

Labels
package:ui type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 11
Development

Successfully merging a pull request may close this issue.

t/238: The dropdown menu should not open using the keyboard when disabled ckeditor/ckeditor5-ui
2 participants
@oleq @mlewand